basho / riak_pipe

Riak Pipelines
Apache License 2.0
162 stars 60 forks source link

Fix invalid return value in riak_pipe_qcover_fsm #42

Closed jtuple closed 12 years ago

jtuple commented 12 years ago

The process_results function in riak_pipe_qcover_fsm incorrectly returns {{error, Reason}, State} when it should return {error, Reason}. The qcover module implements a coverage FSM that is driven by riak_core_coverage_fsm, which passes the error from process_results to the finish function, which expects {error, Reason}. This problem manifests itself with the following match failure:

[error] <0.28297.0> CRASH REPORT Process <0.28297.0> with 2 neighbours crashed with reason: no function clause matching
  riak_pipe_qcover_fsm:finish({{error,worker_limit_reached},                                                           
                               {state,{raw,408228,<0.28284.0>}}},                                                      
                              {state,{raw,408228,<0.28284.0>}})                                                        
jonmeredith commented 12 years ago

+1 merge