search

basho / riak_repl

Riak DC Replication
Apache License 2.0
56 stars 32 forks source link

WIP - consistent object hashing using vclocks #745

Closed JeetKunDoug closed 8 years ago

JeetKunDoug commented 8 years ago

DO NOT MERGE - for discussion

JeetKunDoug commented 8 years ago

FYI - A few comments, but generally looks good.

bsparrow435 commented 8 years ago

This is now ready for merge and depends on https://github.com/basho/riak_kv/pull/1473

nickelization commented 8 years ago

What's the standard upgrade path for customers using replication? Are they supposed to be able to arbitrarily upgrade clusters one at a time, or is there a particular sequence they're supposed to follow, or...? I just ask because I'm wondering about the implications of adding version data to the ?MSG_LOCK_TREE message.

nickelization commented 8 years ago

+1 4c676bc

nickelization commented 8 years ago

(+1ing despite failed checks, since we were able to confirm that the xref/dialyzer failures were just due to basho/riak_kv#1473 not being merged yet.)

nickelization commented 8 years ago

@borshop retry

nickelization commented 8 years ago

@borshop: retry

nickelization commented 8 years ago

Ugh, okay, I give up. I guess Bors won't retry. Tests and stuff pass locally, so I'll go ahead and merge, and then manually verify everything still looks good afterward.

nickelization commented 8 years ago

@borshop merge

nickelization commented 8 years ago

I give up. Bors, we're dunzo.

https://www.youtube.com/watch?v=acLp0S3K6mk