basho / yokozuna

Riak + Solr
245 stars 76 forks source link

yokozuna-2.1.7 maybe merged siblings not passed to get_ops_for_entry_action [JIRA: RIAK-3073] #712

Open fadushin opened 7 years ago

fadushin commented 7 years ago

During investigation, we found that the merged object (possibly with siblings) is not passed to get_ops_for_entry_action at:

https://github.com/basho/yokozuna/blob/2.1.7/src/yz_solrq_helper.erl#L201

This can result in generation of siblings in Solr if the supplied Riak object has multiple contents.

It turns out that this scenario is tested in the yz_crdt test in the riak_test repo, but the test passes under Riak 2.2.0, which include 2.1.7. This should be fixed, however, in 2.2.1. It does show up as a bug in the back port to the Riak 2.0 branch, so it will be fixed in 2.0.x.