Closed bashtage closed 2 months ago
Hello @bashtage! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
randomgen/__init__.py
:Line 41:1: F822 undefined name 'Generator' in all Line 41:1: F822 undefined name 'ExtendedGenerator' in all Line 41:1: F822 undefined name 'RandomState' in all
randomgen/tests/test_direct.py
:Line 41:1: F401 'randomgen.tests.data.compute_hashes.kwargs' imported but unused Line 226:9: F811 redefinition of unused 'kwargs' from line 41 Line 533:42: F811 redefinition of unused 'kwargs' from line 41 Line 970:42: F811 redefinition of unused 'kwargs' from line 41 Line 1354:9: F811 redefinition of unused 'kwargs' from line 41 Line 1575:42: F811 redefinition of unused 'kwargs' from line 41 Line 1578:9: F841 local variable 'key' is assigned to but never used Line 1869:42: F811 redefinition of unused 'kwargs' from line 41
randomgen/tests/test_smoke.py
:Line 154:55: E231 missing whitespace after ':' Line 609:13: F841 local variable 'out_of_bounds' is assigned to but never used Line 973:13: F841 local variable 'out_of_bounds' is assigned to but never used Line 979:9: F841 local variable 'error_type' is assigned to but never used Line 989:5: E303 too many blank lines (2)
Attention: Patch coverage is 99.51220%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 88.29%. Comparing base (
121280c
) to head (d28f75f
).
Files with missing lines | Patch % | Lines |
---|---|---|
randomgen/common.pyx | 90.90% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Work to make Randomgen build and work on NumPy 2