bashtage / randomgen

Numpy-compatible bit generators and add some random variate distributions missing from NumPy.
Other
112 stars 25 forks source link

ENH: Numpy 2 Compatability #365

Closed bashtage closed 2 months ago

bashtage commented 2 months ago

Work to make Randomgen build and work on NumPy 2

pep8speaks commented 2 months ago

Hello @bashtage! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 41:1: F822 undefined name 'Generator' in all Line 41:1: F822 undefined name 'ExtendedGenerator' in all Line 41:1: F822 undefined name 'RandomState' in all

Line 41:1: F401 'randomgen.tests.data.compute_hashes.kwargs' imported but unused Line 226:9: F811 redefinition of unused 'kwargs' from line 41 Line 533:42: F811 redefinition of unused 'kwargs' from line 41 Line 970:42: F811 redefinition of unused 'kwargs' from line 41 Line 1354:9: F811 redefinition of unused 'kwargs' from line 41 Line 1575:42: F811 redefinition of unused 'kwargs' from line 41 Line 1578:9: F841 local variable 'key' is assigned to but never used Line 1869:42: F811 redefinition of unused 'kwargs' from line 41

Line 154:55: E231 missing whitespace after ':' Line 609:13: F841 local variable 'out_of_bounds' is assigned to but never used Line 973:13: F841 local variable 'out_of_bounds' is assigned to but never used Line 979:9: F841 local variable 'error_type' is assigned to but never used Line 989:5: E303 too many blank lines (2)

Comment last updated at 2024-09-17 08:24:21 UTC
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 99.51220% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.29%. Comparing base (121280c) to head (d28f75f).

Files with missing lines Patch % Lines
randomgen/common.pyx 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #365 +/- ## ========================================== - Coverage 92.93% 88.29% -4.64% ========================================== Files 53 50 -3 Lines 8546 8277 -269 Branches 493 490 -3 ========================================== - Hits 7942 7308 -634 - Misses 572 937 +365 Partials 32 32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.