bashtage / sphinx-material

A material-based, responsive theme inspired by mkdocs-material
Other
317 stars 91 forks source link

Extension broken since Sphinx 7.2.0 #137

Closed Grokzen closed 1 year ago

Grokzen commented 1 year ago

We noticed that Sphinx have deprecated old os.path lib and moved over to new Path lib since version 7.2.2 in the following commit https://github.com/sphinx-doc/sphinx/commit/49d830467098cc149390bc8349c19b7501e0920f in the following MR https://github.com/sphinx-doc/sphinx/pull/11526 that caused a breaking change that cause the latest release of this lib to break down

Due to this change that the variable app.outdir is now a PosixPath instead of a str. This cause the following line of code https://github.com/bashtage/sphinx-material/blob/ac7444216f4d2a568ff9d7cfe386929537f7344d/sphinx_material/__init__.py#L74 to break down as it can't join PosixPath + str. The exception we get is TypeError: unsupported operand type(s) for +: 'PosixPath' and 'str' but the stacktrace is not existing in sphinx errors.

We will fork this and submit a PR and use our fork for now until this can be released with a fix