search

bashtage / sphinx-material

A material-based, responsive theme inspired by mkdocs-material
Other
317 stars 91 forks source link

Fix a compatibility issue introduced in Sphinx 7.2.0 and later that changes path handling to Pathlib #138

Closed Grokzen closed 1 year ago

Grokzen commented 1 year ago

Fixes #137

bashtage commented 1 year ago

TGTM. Will commit after the run and do a quick release.

bashtage commented 1 year ago

Thanks. There was another bug in the site docs that needed to be fixed to get the CI to run.

Grokzen commented 1 year ago

@bashtage Perfect, thank you for the quick fix/release :)

Grokzen commented 1 year ago

@bashtage I must caution a little tho. We only struck this error, and my PR only solved the issue we faced. I can't say for sure as we have not looked through the entire code base for all uses of this changed variable or the other ones that they changed out in the PR from sphinx. There might be more issues that we did not reached yet.