bashu / django-easy-maps

🗺 Google Maps with easy!
MIT License
145 stars 56 forks source link

Assuming integer values for width/height #53

Open tombakas opened 8 years ago

tombakas commented 8 years ago

This prevents the users from entering percentages as values. Code from _easy_maps/templatetags/easy_mapstags.py:

...
options = Options(
        Argument('address', resolve=True, required=True),
        IntegerArgument('width', required=False, default=None),
        IntegerArgument('height', required=False, default=None),
        IntegerArgument('zoom', required=False, default=16),
        'using',
        Argument('template_name', default=None, required=False),
    )
...

I'd suggest turning these into Argument instances and adjusting the code in the html template accordingly.

alexeiramone commented 8 years ago

I had the same issue and downgraded easy_maps in order to keep maps ok in the responsive template

tombakas commented 8 years ago

Unfortunately, the project doesn't seem to be actively maintained.

On 4 July 2016 at 15:33, Alexei Martchenko notifications@github.com wrote:

I had the same issue and downgraded easy_maps in order to keep maps ok in the responsive template

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bashu/django-easy-maps/issues/53#issuecomment-230280201, or mute the thread https://github.com/notifications/unsubscribe/ABgcmc-3OVMLxzo-Jpvb-JcYGO8eV0qwks5qSP2BgaJpZM4GLNCm .

bashu commented 7 years ago

@tombakas not sure if this need, all you need is to override / extend default easy_maps/map.html, for example https://github.com/bashu/django-easy-maps/blob/develop/example/templates/easy_maps/responsive.html

bashu commented 7 years ago

@alexeiramone see comment above, let me know if this helps or not

bashu commented 5 years ago

@tombakas @alexeiramone feel free to reopen if it's still an issue

aoulaa commented 3 years ago

for some reason it's not working https://github.com/bashu/django-easy-maps/issues/53#issuecomment-252577441

bashu commented 2 years ago

@aoulaa how it does not working? can you check updated responsive.html template