search

basicallydan / forkability

:fork_and_knife: A linter for your repository.
https://basicallydan.github.io/forkability
MIT License
103 stars 19 forks source link

Change the way suggestions are displayed #32

Open hpoom opened 9 years ago

hpoom commented 9 years ago

As suggested in issue #31 I think we should move away from a popup and instead expand out the warnings that appear to show more information on the warning.

basicallydan commented 9 years ago

I agree. A whole new page would be a good idea but only if you can quickly go back to your lint results. The way it works atm should be easy to extend a bit.

If not the popup will probably get too big!

hpoom commented 9 years ago

How about we have a suggestions folder, we then have each suggestion in a Markdown file. One file per suggestion. These can then be edited and maintained. We can then pull that markdown either into the CLI or into the GH Pages by using a markdown to HTML converter.

We can then use these suggestions with the popup for now, but easy to change and use in another way. Maybe an collapsible suggestions off the warnings? http://getbootstrap.com/javascript/#collapse

basicallydan commented 9 years ago

Yes, that would work fine - although I'm not sure whether it'd look good on the CLI, so to start with just getting it in gh-pages would do!

As for using the Bootstrap collapsible, this also sounds like a good plan :)

piperhaywood commented 8 years ago

I might just try to take a quick look at this as part of a 24 Pull Requests event! First time looking at an issue on an open source project... :)

basicallydan commented 8 years ago

@piperhaywood Welcome to open source! And great, go for it. If you wanna discuss anything lengthy or overly technical feel free to do so here, its good to have a paper trail - for more quick questions which maybe don't need to be on github https://gitter.im/basicallydan/forkability is better :) me and @m-zuber often hang out there.

Also, thanks for showing an interest in contributing!

M-Zuber commented 8 years ago

I second @basicallydan. Welcome to the wonderful world of open source. Happy to help out with anything you need.

p.s. feel free to ping me if you are interested in help on other projects as well

piperhaywood commented 8 years ago

@basicallydan @M-Zuber Thanks very much! Got a little ways with it yesterday, I'm hoping to take a further look at it shortly and submit a PR later this week :)

M-Zuber commented 8 years ago

Great! Thank you for the update. If you want any feedback on the code, even if you think it is not ready to merge, just open a PR with [WIP] in the title

basicallydan commented 8 years ago

:+1: to @M-Zuber's comment.

M-Zuber commented 8 years ago

Hello @piperhaywood, Just checking in. I am aware that there is such a thing as life, so please do not feel pressured.

piperhaywood commented 8 years ago

Thanks for checking in! I've been visiting my folks in the states for the holidays and have been pretty lax with projects and such. Will try to take a look when I'm back!

On 27/12/2015 09:17, Mordechai Zuber wrote:

Hello @piperhaywood https://github.com/piperhaywood, Just checking in. I am aware that there is such a thing as life, so please do not feel pressured.

— Reply to this email directly or view it on GitHub https://github.com/basicallydan/forkability/issues/32#issuecomment-167419763.

basicallydan commented 8 years ago

@piperhaywood No problem, I've been in almost exactly the same position. Hope you had a good break :+1:

M-Zuber commented 8 years ago

Have fun!!