search

basicallydan / forkability

:fork_and_knife: A linter for your repository.
https://basicallydan.github.io/forkability
MIT License
103 stars 19 forks source link

“Uncommented issue” should not be flagged when the issue was opened by non-owner maintainer e.g. with orgs #57

Open Kwpolska opened 9 years ago

Kwpolska commented 9 years ago

The maintainers might create issues to track their task, as a to-do list.

basicallydan commented 9 years ago

Agreed! In fact, with this in mind I originally set up the code so that if the user who opened the issue is the same as the user who owns the repo, it won't count as a problem. I think in 90% of cases, the to-do list use case will be fine. For instance, this uncommented issue does not show up as a problem with Forkability because I created it.

However, I did not account for the possibility that multiple people may be maintainers, or that the repo may be owned by an organisation. Do you mind if I edit your issue slightly to reflect these things?

Kwpolska commented 9 years ago

Do it.

Chris Warrick https://chriswarrick.com/ Sent from my Galaxy S3. On 1 Sep 2015 5:19 pm, "Daniel Hough" notifications@github.com wrote:

Agreed! In fact, with this in mind I originally set up the code so that if the user who opened the issue is the same as the user who owns the repo, it won't count as a problem. I think in 90% of cases, the to-do list use case will be fine. For instance, this uncommented issue https://github.com/basicallydan/forkability/issues/10 does not show up as a problem with Forkability because I created it.

However, I did not account for the possibility that multiple people may be maintainers, or that the repo may be owned by an organisation. Do you mind if I edit your issue slightly to reflect these things?

— Reply to this email directly or view it on GitHub https://github.com/basicallydan/forkability/issues/57#issuecomment-136757736 .