Add shrinkwrap to the makefile

basicallydan / forkability

:fork_and_knife: A linter for your repository.

https://basicallydan.github.io/forkability

MIT License

103 stars 19 forks source link

Add shrinkwrap to the makefile #76

Closed M-Zuber closed 8 years ago

M-Zuber commented 8 years ago

Steps to implement:

Fork the repo
Update the makefile
- [ ] Add a shrinkwrap command with value of: rm -rf node_modules/ npm-shrinkwrap.json && npm install && npm shrinkwrap
- [ ] Add @echo " shrinkwarp resets the shrinkwrap.json file" to the help command
Make sure it runs, and open a PR

That's it and welcome to open source :grinning: :tada:

basicallydan commented 8 years ago

Great first timers only! You've probably already considered this but I do have a small concern.

Do we definitely want this in the deps task? It means whenever someone clones and runs deps they're potentially making a change to the repo, potentially a chance to the code and therefore potentially a change to functionality. This would defeat essentially the object of shrinkwrap - keeping the code exactly the same for a particular commit.

This is definitely useful, but we need to ensure people don't clone then immediately do this when all they wanna do is reproduce and track down a bug which may well be caused by a specific version of a dependency.

See what I mean? Or am I missing something?

M-Zuber commented 8 years ago

:100: I've updated the issue accordingly. We need to update the documentation to include a mention of the makefile btw

basicallydan commented 8 years ago

Yeah you're right we do. I can do that quickly no prob!

Good update - I can get fully behind this! :)

varjmes commented 8 years ago

Hello! Gonna twoot bout this from @youfirstpr today! Thanks so much for making things.

M-Zuber commented 8 years ago

Thank you. What time are you tweeting as I may have some more for you :wink:

varjmes commented 8 years ago

I only do one every other day, but as my next one would be on Christmas day I could do a bonus round. Tweets usually go out at 1PM :)

M-Zuber commented 8 years ago

I will try and have it ready by then :)

basicallydan commented 8 years ago

Ahhhh so much activity. I will find a coffee shop and try to help :P On 23 Dec 2015 10:31, "Mordechai Zuber" notifications@github.com wrote:

I will try and have it ready by then :)

— Reply to this email directly or view it on GitHub https://github.com/basicallydan/forkability/issues/76#issuecomment-166857725 .

basicallydan commented 8 years ago

Thank you @Charlotteis for the ol' tweetage :)

varjmes commented 8 years ago

Think this can be closed now :)

basicallydan commented 8 years ago

Yes! Thanks Charlotte!

See you some time at some event in London I hope! On 2 Jan 2016 11:54, "Charlotte Spencer" notifications@github.com wrote:

Think this can be closed now :)

— Reply to this email directly or view it on GitHub https://github.com/basicallydan/forkability/issues/76#issuecomment-168384027 .

M-Zuber commented 8 years ago

So it should be closed then? :stuck_out_tongue_closed_eyes:

basicallydan commented 8 years ago

Haha sorry I thought Charlotte had closed it too!

--Dan danhough.com http://www.danhough.com - @basicallydan http://twitter.com/basicallydan

On 3 January 2016 at 16:21, Mordechai Zuber notifications@github.com wrote:

Closed #76 https://github.com/basicallydan/forkability/issues/76.

— Reply to this email directly or view it on GitHub https://github.com/basicallydan/forkability/issues/76#event-504230023.

varjmes commented 8 years ago

I don't have those permissions!