search

basicallydan / forkability

:fork_and_knife: A linter for your repository.
https://basicallydan.github.io/forkability
MIT License
103 stars 19 forks source link

Updated npm-watch and shrink-wrap file #78

Closed andrew closed 8 years ago

andrew commented 8 years ago

:snowboarder:

M-Zuber commented 8 years ago

It seems I was a bit hasty. It would force node 5.2, which I personally don't think is a problem. To me it just means the travis.yaml has to be updated @basicallydan how do you feel about that?

basicallydan commented 8 years ago

@m-zuber what's wrong with travis.yaml being updated? I assume you mean we'd remove support for anything apart from 5.2.

M-Zuber commented 8 years ago

Yeah I was referring to only supporting node 5.2 and up

basicallydan commented 8 years ago

@M-Zuber Right. We eventually will need to go in this direction. But if we start bringing in modern node code into Forkability we also need to start transpiling with Babel or something because of the web app.

Apart from that I see no real problem in upgrading to 5.2. We're still in pre-v1 stage so it wouldn't break the rules of SemVer to do a minor update, but it would probably upset a few people who aren't ready to upgrade to 5.2. Not many though, I expect.

Am I right about that, re: semver? Opinions there would be helpful.

Can we get .travis.yml updated in this, @andrew?

M-Zuber commented 8 years ago

Right now it is a matter of dev dependencies, not a matter of our code so the transpiler issue should still be a bit of a ways off. People who don't want to update yet, probably do not even have to if they really don't want to. I believe you are correct about the semver

andrew commented 8 years ago

Just pushed an update to the .travis.yml config to only test against 5.2 and 5.3 :+1:

basicallydan commented 8 years ago

Ah, big step. Goodbye old node.

basicallydan commented 8 years ago

slowly downloads node stable over shitty Old Street Starbucks wifi

M-Zuber commented 8 years ago

:laughing: :joy: