search

basicallydan / forkability

:fork_and_knife: A linter for your repository.
https://basicallydan.github.io/forkability
MIT License
103 stars 19 forks source link

Make web app language input case-insensitive #90

Closed ExcaliburZero closed 8 years ago

ExcaliburZero commented 8 years ago

This changes the way the web app interprets user entered languages, so that languages are not required to be inputted using a specific case. It also adds a test case for case insensitivity.

This still has a few issues that need to be adressed, and its commits should be squashed before merging. Should eventually fix #82.

M-Zuber commented 8 years ago

Tests pass. Looks great to me. Have you been able to get it to work when running locally?

ExcaliburZero commented 8 years ago

I re-ran make and make serve and it seems to be working now.

I'll squash the commits, and then hopefully it should be about ready to merge.

M-Zuber commented 8 years ago

:shipit: :tada: Thank you very much for the patience and work.

Thanks to you we not only have this change, but a better make file and documentation!!

basicallydan commented 8 years ago

Ah I'm so happy this is finally working. Nice one, guys :+1: