search

basicallydan / forkability

:fork_and_knife: A linter for your repository.
https://basicallydan.github.io/forkability
MIT License
103 stars 19 forks source link

Version 0.18 release #93

Closed basicallydan closed 8 years ago

basicallydan commented 8 years ago

@charlotteis made codes of conduct a requirement. @ExcaliburZero made the language option case-insensitive.

Updated the readme and changelog to reflect this.

:tada:

M-Zuber commented 8 years ago

:tada:

basicallydan commented 8 years ago

@M-Zuber Wait don't merge yet! Just had to add he compiled code. It's v0.18.1 now

M-Zuber commented 8 years ago

Not that we owe semver anything, but what mechanism do you use that forces the increment?

Edit: never mind dumb me. npm right?

basicallydan commented 8 years ago

never mind dumb me. npm right?

Correct! Not dumb. I go npm minor|patch -m "blah blah"

M-Zuber commented 8 years ago

Can I merge btw? :smile:

Maybe the steps for deployment/release should be written up somewhere?

basicallydan commented 8 years ago

Sure, go ahead and merge.

And they should be yes, especially since once we switch to an org I'm hoping you can also make releases :tada: if you want to anyway!

I'll write something up now and make another PR.

One of the ways my current job does PRs is to encourage others to do the merge as it means they've probably had to have checked the code is a-ok. I think we should do it that way.

M-Zuber commented 8 years ago

One of the ways my current job does PRs is to encourage others to do the merge as it means they've probably had to have checked the code is a-ok. I think we should do it that way.

I agree with this. Will check if there is a way to enforce that the merger can not be the PR author.

And they should be yes, especially since once we switch to an org I'm hoping you can also make releases :tada: if you want to anyway!

Since we have decided on the previous item, then anyone who is a collab should be able to make a release - as it is not final until the PR is merged. The npm story does need to be though out though. Maybe the merger is the one that pushes to npm? Otherwise if a PR is made but not merged, you have lost that version on npm. (there is a trick to publishing betas that can not be seen on the site, remind me and I'll tell you later)

M-Zuber commented 8 years ago

Oh, and maybe the @ forkability account on twitter should be telling people about the release?

basicallydan commented 8 years ago

Oh, and maybe the @ forkability account on twitter should be telling people about the release?

On it. Will reply to other thing in a min.

basicallydan commented 8 years ago

Will check if there is a way to enforce that the merger can not be the PR author.

Ah, I dunno if we wanna make it a requirement. Just in case!

Since we have decided on the previous item, then anyone who is a collab should be able to make a release - as it is not final until the PR is merged.

Hmm, maybe. Publishing a release is quite a big deal though! I mean, it can make or break someone's dependent code. Quite a huge responsibility.

Maybe the merger is the one that pushes to npm?

This sounds like a good plan, as long as the merger has npm publish access.

I gotta go teach a keen coder to get their Python environment set up now - I'll get around to the publishing guide soon! Maybe tonight or tomorrow morning. Ugh.

Real life ¯\_(ツ)_/¯