search

basicallydan / forkability

:fork_and_knife: A linter for your repository.
https://basicallydan.github.io/forkability
MIT License
103 stars 19 forks source link

New GitHub Template support #95

Open basicallydan opened 8 years ago

basicallydan commented 8 years ago

GitHub has implemented some features requested by the community for issue and PR templates. It might be a nice idea to support this in Forkability!

https://github.com/blog/2111-issue-and-pull-request-templates

@M-Zuber any thoughts?

M-Zuber commented 8 years ago

To check for it? Off the top of my head I am not so sure about that, as it is more a tool for maintainers. Someone coming into a project might not care that much if a template is provided.

OTH if there was a third category of Suggested I would say it should for sure be included.

basicallydan commented 8 years ago

@M-Zuber Hm. there used to be a warnings section. Not sure why/how I got rid of it.

I'd argue for its inclusion, though, as Forkability isn't just for people coming into a project though: it's helpful for maintainers to know that their repo is accessible, and by providing a template it's more accessible to people.

Having said that, the "required items" list is getting rather large so I'd agree that "warnings" or "suggested" should be reintroduced, and these can be some things that we put in.

M-Zuber commented 8 years ago

:+1: I'm getting settled into a new job, so it will be a few days yet before I can make any solid contributions - whether code or writing up an issue - though.

basicallydan commented 8 years ago

No worries man, just wanted to make sure I wrote it down and got your opinion!

basicallydan commented 8 years ago

@M-Zuber By the way congrats on your new job!

M-Zuber commented 8 years ago

Thank you 😊