search

basicallydan / skifree.js

:ski: The classic PC Game SkiFree, but in JS.
https://basicallydan.github.io/skifree.js
MIT License
511 stars 129 forks source link

Too many trees in Firefox #13

Closed toupeira closed 9 years ago

toupeira commented 10 years ago

I'm using Firefox Aurora 28.0a2 on Debian sid. At the beginning there's always an impossible forest of trees:

screenshot-2014-01-18-14 49 24 856985970

This doesn't happen on Chromium for some reason.

basicallydan commented 10 years ago

I'd love to tell you that you're just failing at the first hurdle and that you should try harder ;) but you're right, this is an impossible line of trees.

I believe it is caused by the fact that trees are always being generated at the same rate regardless of player speed, so I shall endeavour to sort this cruddy behaviour out by having the former proportional to the latter.

Nice bug report, thanks :)

andersevenrud commented 9 years ago

It seems this was fixed as a side-effect of one of my commits (in the pull-request). Not 100% sure, but it sure looks that way.

katerberg commented 9 years ago

This looks fixed to me as well.

toupeira commented 9 years ago

Yep looks fine now :+1: Sorry for not confirming earlier!

basicallydan commented 9 years ago

That's cool thanks for responding @katerberg and @toupeira :)