search

basigek / simbrain

Automatically exported from code.google.com/p/simbrain
0 stars 0 forks source link

Copying specific neuron group subclasses does not copy the specific subclass/Subnetworks can't be copied/pasted #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create a WTA neuron group or SOM or any other, so long as it isn't just a 
regular neuron group
2. Copy and paste that group

1. Create a subnetwork
2. Try to copy and paste it.

The new group will not have the special properties. I.e. if the original neuron 
group was WTA, the pasted group will be just a regular neuron group.

As in the title copy and pasting of subnetworks appears to just not be possible.

At least for the neuron groups, this is easily solved by overriding 
NeuronGroup's copy constructor... though given that this is necessary perhaps 
we should create an abstract version of NeuronGroup so that subclasses MUST 
override that method.

Original issue reported on code.google.com by ZachT...@gmail.com on 27 Aug 2014 at 5:54

GoogleCodeExporter commented 9 years ago 
The only actual problem has now ben fixed: that is, specific groups are now 
faithfully copied. This is the only actual error since we allowed copying of 
these kinds of groups but it just wasn't happening properly. On the other hand, 
since Subnetworks cannot be copied/pasted at all _not_ having that feature is 
not a bug, and a report about it falls under the category of "request for 
enhancement" rather than error.

Thus this issue is being closed:

https://code.google.com/p/simbrain/source/detail?r=3099    shows the fix for 
the group copying problem

and

Subnetwork copying has been turned into a separate issue: 
https://code.google.com/p/simbrain/issues/detail?id=14 this new issue has been 
labeled as a request for enhancement and given low priority.

Original comment by ZachT...@gmail.com on 27 Aug 2014 at 6:51