search

basil00 / Gull

Gull chess (Linux/Mac port)
Other
29 stars 15 forks source link

Boolean bug in knpkx() #10

Closed TomHyer closed 7 years ago

TomHyer commented 7 years ago

Line 1768 (as of Feb 2017) contains the parenthesized quantity DATA->SArea[lsb(King(me))] && DATA->SArea[lsb(King(opp))] & Line(me, 7)

The use of '&&' here is wrong (SArea[j] is always nonzero). It should be '&' as on line 1773.

basil00 commented 7 years ago

Yes, another good catch.

Btw, if you like you should submit a (one line) patch as a pull request. That way you get credit for the fix and also be listed as a contributor.

TomHyer commented 7 years ago

I'll try. I suck at MinGW, haven't built your code yet.

On Mar 2, 2017, at 7:14 PM, basil00 notifications@github.com wrote:

Yes, another good catch.

Btw, if you like you should submit a (one line) patch as a pull request. That way you get credit for the fix and also be listed as a contributor.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

basil00 commented 7 years ago

In this case the change is so trivial it should not require testing.