search

basilfx / TRADFRI-Hacking

Hacking IKEA TRÅDFRI products, such as light bulbs, window blinds and other accessories.
632 stars 62 forks source link

Document ICPSLC24-10NA #14

Closed oliv3r closed 5 years ago

oliv3r commented 6 years ago

This series adds the teardown and schematics of the ICSPLC24-10NA PWM output controller module found in LED drivers such as the ICPSHC24-30EU-IL-1 and ICSHC24-10EU-IL-1.

Signed-off-by: Olliver Schinagl oliver@schinagl.nl

oliv3r commented 6 years ago

anything else you want to see changed here @basilfx ?

oliv3r commented 5 years ago

@basilfx Anything you want done or added for this merge?

basilfx commented 5 years ago

Hey @oliv3r, thanks for this PR. I have been really busy with other things (and holidays) that I just don't have the time. Sorry!

I only have a comment on where the schema resides: I'd like to keep the pcb/ folder for things we can build. One suggestion is to move this to the teardowns/ folder? What do you think? Maybe we have to split the teardown folder per project into pictures and schemas then.

oliv3r commented 5 years ago

To be fair, we CAN build it using the schematics :) but I do agree, it is far better suited to be put under teardowns.

I'll think of some scheme to split the pictures and schemas as well though your suggestion makes quite sense. I'll rework the others once I've glanced at it.

oliv3r commented 5 years ago

After a quick peek at the others, there's no need to clean anything in the current state yet. So I only reworked this one and moved the files around as per request. So @basilfx you can merge this one if there's nothing else, and I'll rebase and cleanup the other PR's.

basilfx commented 5 years ago

Looks good, thanks!