basilio / responsiveCarousel

Simple carousel
MIT License
113 stars 64 forks source link

Images are not showing #9

Closed dlzi closed 11 years ago

dlzi commented 11 years ago

Hey Basilio,

I'm having an issue here. Suddenly the images are not showing. You can check here: http://begun.theux.co/

If you pass the mouse hover between the logo and text, you will see the controls working, but none image.

Any idea?

basilio commented 11 years ago

Hi Daniel, One of the updates that i made was create a special class for images with full-width size (inside each crsl-item) Maybe if you add .wide-image to your images, or specify it in your script using imageWideClass resolve the problem. Bye

2013/9/16 Daniel notifications@github.com

Hey Basilio,

I'm having an issue here. Suddenly the images are not showing. You can check here: http://begun.theux.co/

If you pass the mouse hover between the logo and text, you will see the controls working, but none image.

Any idea?

— Reply to this email directly or view it on GitHubhttps://github.com/basilio/responsiveCarousel/issues/9 .

Basilio Cáceres Luke Diseñador Gráfico y Desarrollador Web twitter: @basilio skype: basiliocaceres

www.isotipo.net | www.ayerviernes.com | www.clerkhotel.com

dlzi commented 11 years ago

Hey,

I don't think is that case, I just setup a simple carousel with multiple elements. Is there any additional CSS that I need to use for that?

basilio commented 11 years ago

Nop, this use only the styles declared on the script. Maybe this can be the problem? http://begun.theux.co/wp-content/plugins/theux-carousel/assets/js/public.js?ver=1.0.0 Apparently you're not declaring the parameters.

2013/9/16 Daniel notifications@github.com

Hey,

I don't think is that case, I just setup a simple carousel with multiple elements. Is there any additional CSS that I need to use for that?

— Reply to this email directly or view it on GitHubhttps://github.com/basilio/responsiveCarousel/issues/9#issuecomment-24521844 .

Basilio Cáceres Luke Diseñador Gráfico y Desarrollador Web twitter: @basilio skype: basiliocaceres

www.isotipo.net | www.ayerviernes.com | www.clerkhotel.com

dlzi commented 11 years ago

Actually I'm. If you see the page's source code you see will at the bottom of the page

/* <![CDATA[ */
var tusparams = {"visible":"2","speed":"fast","overflow":"false","autorotate":"false","minwidth":"0","margin":"0","equalheight":"false","carousel":"true"};
/* ]]> */
basilio commented 11 years ago

You`re right. ¿Maybe case-sensitive? Properties use camel-case system: autoRotate, minWidth, itemMargin, etc

2013/9/16 Daniel notifications@github.com

Actually I'm. If you the page's source code you will at the bottom of the page

/* <![CDATA[ / var tusparams = {"visible":"2","speed":"fast","overflow":"false","autorotate":"false","minwidth":"0","margin":"0","equalheight":"false","carousel":"true"}; / ]]> */

— Reply to this email directly or view it on GitHubhttps://github.com/basilio/responsiveCarousel/issues/9#issuecomment-24522467 .

Basilio Cáceres Luke Diseñador Gráfico y Desarrollador Web twitter: @basilio skype: basiliocaceres

www.isotipo.net | www.ayerviernes.com | www.clerkhotel.com

dlzi commented 11 years ago

Those are just variables. I put some console.log for you to see. The parameters are being passed.

basilio commented 11 years ago

Hey Daniel, I know whats going on. Some of your variables are passed as string, instead of boolean or int. For example:

I will add some extra validation to prevent this kind of error, but meanwhile you will could to change this and all will work normally Cheers

2013/9/16 Daniel notifications@github.com

Those are just variables. I put some console.log for you to see. The parameters are being passed.

— Reply to this email directly or view it on GitHubhttps://github.com/basilio/responsiveCarousel/issues/9#issuecomment-24523820 .

Basilio Cáceres Luke Diseñador Gráfico y Desarrollador Web twitter: @basilio skype: basiliocaceres

www.isotipo.net | www.ayerviernes.com | www.clerkhotel.com

dlzi commented 11 years ago

Hey.. you are right.

The validation will be a nice touch ;-)

Thanks a lot!