search

basiliscos / cpp-bredis

Boost::ASIO low-level redis client (connector)
MIT License
147 stars 36 forks source link

Fix deprecated api #30

Closed miximtor closed 5 years ago

miximtor commented 5 years ago

Fix deprecated api for boost 1.70.0 compatbility

basiliscos commented 5 years ago

Thank you for your PR. I'll look at it in more details in the weekends. Do you know, why some tests fail?

miximtor commented 5 years ago

@basiliscos I pass all test case on linux, Boost version 1.70，I'll try to fix this on boost version 1.69, It seems like that std::decay_t<WriteCallback> and std::decay_t<ReadCallback> cause the fail

basiliscos commented 5 years ago

@miximtor I incuded your patch into experimental branch (https://github.com/basiliscos/cpp-bredis/pull/31 ) . The failing tests seems are related to use_future bug in previous boost::asio versions ( https://github.com/boostorg/asio/issues/226 ).

I'll wait a week, and if there will be no reaction, I'll merge my branch and close this one (as I need other features from boost::asio v1.70). Don't you mind, if I'll include you in contributors, then?

miximtor commented 5 years ago

That's ok.I dont mind it@basiliscos

basiliscos commented 5 years ago

Merged to master and released v0.07. Closing PR. Thank you, again!