install.bat paths not correct (windows)

[andreirt]

Dear BasilJS team,

at color.jsx, for example, we have:

#includepath "~/Documents/;%USERPROFILE%Documents";
#include "basiljs/bundle/basil.js";

To this work at Windows, I had to

1. add a slash before Documents

   #includepath "~/Documents/;%USERPROFILE%/Documents";

2. change install.bat from

md   %userprofile%\Documents\basiljs-target
xcopy . %userprofile%\Documents\basiljs-target\bundle\ /E
md %userprofile%\Documents\basiljs-target\user

to

md   %userprofile%\Documents\basiljs
xcopy . %userprofile%\Documents\basiljs\bundle\ /E
md %userprofile%\Documents\basiljs\user

I am thinking about changing this and submitting a pull request. Does this seem ok for you?

Best, Andrei

[trych]

Hi Andrei, thanks for reporting an issue. The paths in the install.bat seem definitely wrong, they should not point to basiljs-target.

About the slash before Documents I am not sure. I have some students in my basil.js course using Windows that did not have any problems using the current

#includepath "~/Documents/;%USERPROFILE%Documents";

Could you double check if the problems are not resolved simply by changing basiljs-target to basiljs (without changing the include path)? Unfortunately we cannot really test this easily, as we are all working on OS X.

[ff6347]

@andreirt Which Windows version are you on and on which ID version are you working?

I will setup a testing environment for Windows in a VM next year.

[andreirt]

@trych indeed, after changing the path basiljs-target to basiljs at install.bat, all the scripts worked, without changing the include path.

@fabianmoronzirfas I am using Windows 10. By ID version do you mean BasilJS version or CC version? The CC version is the last one, and the BasilJS version is the one can be downloaded at BasilJS website., 1.0.10.

[trych]

@andreirt Cool, then this seems to be the only problem. Feel free to do a pull request to fix this.

You will need to do the pull request against the develop branch, not the master branch. The install.bat script will most likely be expanded in the near future as we are in the process of changing the folder structure of basil.js, but it won't hurt to fix the incorrect paths right now.

[andreirt]

I downloaded the fix today, it worked ;-)