Handling of package-lock.json file?

trych commented 7 years ago

I am starting to migrate my environment over to the official basil.js repo, so I don't have to work from my own fork anymore, as requested by others here.

When I did the npm install, there was a package-lock.json file added to my repo. I am not familiar with these files, but the docs here say, that

This file is intended to be committed into source repositories

So, should I just commit it? @fabianmoronzirfas Could you shed some light on this? 😎

trych commented 7 years ago

Looks like this btw.

{
  "name": "basiljs",
  "version": "1.1.0",
  "lockfileVersion": 1,
  "dependencies": {
    "abs": {
      "version": "1.3.8",
      "resolved": "https://registry.npmjs.org/abs/-/abs-1.3.8.tgz",
      "integrity": "sha1-ACi49Qa6/TN3BvKjwFuIFj7kORA=",
      "dev": true
    },
    "acorn": {
      "version": "5.0.3",
      "resolved": "https://registry.npmjs.org/acorn/-/acorn-5.0.3.tgz",
      "integrity": "sha1-xGDfCEkUY/AozLguqzcwvwEIez0=",
      "dev": true
    },
    "acorn-jsx": {
      "version": "3.0.1",
      "resolved": "https://registry.npmjs.org/acorn-jsx/-/acorn-jsx-3.0.1.tgz",
      "integrity": "sha1-r9+UiPsezvyDSPb7IvRk4ypYs2s=",
      "dev": true,
      "dependencies": {
        "acorn": {
          "version": "3.3.0",
          "resolved": "https://registry.npmjs.org/acorn/-/acorn-3.3.0.tgz",
          "integrity": "sha1-ReN/s56No/JbruP/U2niu18iAXo=",
          "dev": true
        }
      }
    },
    "ansi-html": {
      "version": "0.0.7",
      "resolved": "https://registry.npmjs.org/ansi-html/-/ansi-html-0.0.7.tgz",
      "integrity": "sha1-gTWEAhliqenm/QOflA0S9WynhZ4=",
      "dev": true
    },
    "ansi-regex": {
      "version": "2.1.1",
      "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-2.1.1.tgz",
      "integrity": "sha1-w7M6te42DYbg5ijwRorn7yfWVN8=",
      "dev": true
    },
    "ansi-styles": {
      "version": "2.2.1",
      "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-2.2.1.tgz",
      "integrity": "sha1-tDLdM1i2NM914eRmQ2gkBTPB3b4=",
      "dev": true
    },
    "anymatch": {
      "version": "1.3.0",
      "resolved": "https://registry.npmjs.org/anymatch/-/anymatch-1.3.0.tgz",
      "integrity": "sha1-o+Uvo5FoyCX/V7AkgSbOWo/5VQc=",
      "dev": true
    },
    "argparse": {
      "version": "1.0.9",
      "resolved": "https://registry.npmjs.org/argparse/-/argparse-1.0.9.tgz",
      "integrity": "sha1-c9g7wmP4bpf4zE9rrhsOkKfSLIY=",
      "dev": true
    }

etc.

ff6347 commented 7 years ago

Hey @trych long time no see/write/hear/whatever. Yes the package-lock.json file should be commited. This is new in npm v5 which gets installed by default when you use node 8. It locks down the versions of the installed modules. Which is a good thing. This might shed some light on it http://jpospisil.com/2017/06/02/understanding-lock-files-in-npm-5.html

trych commented 7 years ago

Ok, I'll commit it then, I consider this reviewed by you now. ;)

ff6347 commented 7 years ago

If the build process works on node 8 go ahead.

trych commented 7 years ago

Yep, gave it a quick test, seems to work just fine. Merged in the package-lock.json file.

basiljs / basil.js

Handling of package-lock.json file? #195