Missing results in references search

basiljs / basiljs.github.io

W.I.P. Basil.js reference build with jekyll and documentation.js

https://basiljs2.netlify.app

Other

5 stars 0 forks source link

Missing results in references search #204

Open ffd8 opened 4 years ago

ffd8 commented 4 years ago

I first noticed this issue the other week while searching the references for random, which only lists:

Math#Random (just text, not a link to click on.. should be?)
randomSeed(seed)
placeholder(textFrame)
noise(x, [y], [z])
noiseSeed(seed)

.. surprisingly not the random() function itself.

Did a search today with students for max + max() to demonstrate max of arrays, but the results were only:

constrain(aNumber, aMin, aMax)
inspect(obj, [settings])

Searching for ceil finds it without an issue, even though they're in the same sub-category...

Curious if it's an issue with the inline documentation (don't see a difference in src) or the parsing of it for the search module?

ff6347 commented 4 years ago

The search index is based on this document. https://basiljs2.netlify.app/reference/lunrjs.data.json I’ll noticed that myself. I’ll investigate

https://github.com/nextapps-de/flexsearch

ff6347 commented 4 years ago

Note to self. Rename it fun lunr to flexsearch

ffd8 commented 4 years ago

Quick followup on this – I'm guessing the search is ignoring any functions that have the same name as a subhead? While trying to search for text – it doesn't list the actual text() function.. same with vertex (also has a subhead).

ff6347 commented 4 years ago

Okay. Thanks. I will review this. I started a rewrite with less Markup and better responsibility. I also will be on parental leave from November till mid January and hope to get this onto the road then.

I know you will say: "noooooo not a rewrite!! 😱 " but the code for the current site has gotten so messy that every time I touched one thing something else broke. So I started from scratch with eleventy as SSG and now builds are 10000000000 faster and it is based on the Bulma framework (which is way smarter then I'll ever could write CSS). Anyhow I'll move my current state to the org as soon as I have the base functionality we already have replicated. I will rewrite the search as well and then we can hopefully close this on.