search

basiljs / examples

2 stars 1 forks source link

This link should be broken or not? #10

Open ff6347 opened 5 years ago

ff6347 commented 5 years ago

https://github.com/basiljs/examples/blob/1ec38b53c012ef8482aa61407e49156ae66eb8d4/input/loadStringURL.jsx#L11

trych commented 5 years ago

Yes. This is fixed already in the develop branch: See here

ff6347 commented 5 years ago

Cool. In the tutorials this is also broken (see https://github.com/basiljs/basiljs.github.io/issues/69) https://github.com/basiljs/basiljs.github.io/blob/develop/tutorials/12-data-csv/index.md#preparations points to https://github.com/basiljs/basil.js/blob/master/examples/demos/B08_bar_chart_from_csv_data/data/LA_Pools-Pools_per_Hood.csv

I'm wondering the link you have there is pointing to the master branch of the main basiljs repo. But the source for the exampels is located in this repo?

ff6347 commented 5 years ago

Once we merge develop into master this will be broken again.

trych commented 5 years ago

Haha, true. Hm, we probably should set up a folder in the examples repo itself, where we keep these files.