basis-company / nats.php

nats jetstream client for php
116 stars 29 forks source link

pinging after publish #70

Closed ro0NL closed 4 months ago

ro0NL commented 4 months ago

related to #68

now we see endless pinging afer publish every now&then

16:15:44 DEBUG     [messenger] send CONNECT
16:15:44 DEBUG     [messenger] send SUB handler.b6de490c bf07f53d
16:15:44 DEBUG     [messenger] send PUB $JS.API.CONSUMER.MSG.NEXT.test.test handler.b6de490c 26
{"batch":1,"no_wait":true}
16:15:47 DEBUG     [messenger] sleep
16:15:52 DEBUG     [messenger] sleep
16:15:57 DEBUG     [messenger] send PING
16:15:57 DEBUG     [messenger] sleep
16:16:02 DEBUG     [messenger] sleep
16:16:07 DEBUG     [messenger] sleep
16:16:12 DEBUG     [messenger] send PING
nekufa commented 4 months ago

@ro0NL check this with the latest release. if bug stil present, is there any chance to reproduce it using tests? btw, do you plan to publish messenger nats transport as a package?

ro0NL commented 4 months ago

thanks for working on this!

i've prepared a release on our side, will test tomorrow: https://github.com/etrias-nl/php-toolkit/commit/34b3b738a2aec94633061968de40dcc60a57e7eb

messenger transport is currently already published as a package ;) https://packagist.org/packages/etrias/php-toolkit

nekufa commented 4 months ago

@ro0NL i mean only transport, not whole application framework :) like we did with tarantool store for symfony lock package https://github.com/tarantool-php/symfony-lock

ro0NL commented 4 months ago

it contains only our reuseable infrastructural code :angel: so 'cherry pick what you need' approach, this works best for us maintenance wise.

i might propose the transport layer in symfony core at some time, but not sure yet. In the end it's just our glueing code.

overall release 0.19.1 seems to solve the issue, i havent spotted any 'zombie workers' yet

thanks!