search

baskerville / bspwm

A tiling window manager based on binary space partitioning
BSD 2-Clause "Simplified" License
7.79k stars 414 forks source link

install target keeps file permissions and owner #984

Open ilohmar opened 5 years ago

ilohmar commented 5 years ago

This seems to be done deliberately, but it's quite unusual and causes multiple problems, eg, if the user has set a non-std umask (I have 0077): After the typical sudo make install, man pages and executables are not readable by root, so they are not indexed etc..

Would you be willing to accept a PR that uses the "install" tool instead of cp, in order to fix this? It would use the std 0644 or 755 permissions and in the sudo case, would install files as root.

Same goes for sxhkd and xdo.

baskerville commented 5 years ago

Yes, I would accept a PR.

ilohmar commented 5 years ago

Great, will hopefully get to do that soon!