baskerville / plato

Document reader
Other
1.26k stars 105 forks source link

Use cargo workplaces #262

Closed paulrouget closed 2 years ago

paulrouget commented 2 years ago

I managed to remove all the warnings.

Please let me know if there's any changes you're not happy with:

I'm still having this warning when cross compiling.

More details here and here.

warning: unknown feature specified for `-Ctarget-feature`: `a9`
  |
  = note: it is still passed through to the codegen backend
  = note: consider filing a feature request
paulrouget commented 2 years ago

Fix #256

baskerville commented 2 years ago

Thanks!

I've only found a small mistake in service.sh for the install_importer case: the correct invocation is cargo install --path crates/importer "$@" and not cargo install --path . -p plato-importer "$@".

Regarding the remaining warning, I think I understand why it shows a warning: in the output of rustc --print target-features --target arm-unknown-linux-gnueabihf, a9 isn't in the rustc table (but is in the LLVM table) while all the other features used in .cargo/config (v7, vfp3, neon) are in the rustc table.

paulrouget commented 2 years ago

I've only found a small mistake in service.sh

Fixed

Regarding the remaining warning

I'll file a rustc issue for that. Thank you.

baskerville commented 2 years ago

I'm getting a few errors when I try to build the article fetcher with cargo +nightly build --profile release-minsized -Z build-std=std,panic_abort --target arm-unknown-linux-gnueabihf -p fetcher (for example: error: cannot determine resolution for the macro json).

baskerville commented 2 years ago

What seems to be causing it is -Z build-std=std,panic_abort.

paulrouget commented 2 years ago

I've seen that before. I think it's a crate name mixup. core:: show be renamed. I'll give it a try later.

paulrouget commented 2 years ago

@baskerville can you try with the last commit?