basmith / sparsehash

Automatically exported from code.google.com/p/sparsehash
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

fix virtual destructor warnings in unit tests #56

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. configure on CentOS 4.8
2. make

What is the expected output? What do you see instead?

/u/gaul/work/sparsehash-1.7/src/sparsehashtable_test.cc:88: warning: `class 
<unnamed>::SparsehashtableTest' has virtual functions but non-virtual destructor
/u/gaul/work/sparsehash-1.7/src/sparsehashtable_test.cc:104: warning: `class 
<unnamed>::TEST_Basic' has virtual functions but non-virtual destructor
/u/gaul/work/sparsehash-1.7/src/sparsehashtable_test.cc:144: warning: `class 
<unnamed>::TEST_Insert' has virtual functions but non-virtual destructor
/u/gaul/work/sparsehash-1.7/src/sparsehashtable_test.cc:200: warning: `class 
<unnamed>::TEST_Find' has virtual functions but non-virtual destructor
/u/gaul/work/sparsehash-1.7/src/sparsehashtable_test.cc:215: warning: `class 
<unnamed>::TEST_Erase' has virtual functions but non-virtual destructor
/u/gaul/work/sparsehash-1.7/src/sparsehashtable_test.cc:265: warning: `class 
<unnamed>::TEST_ReadWrite' has virtual functions but non-virtual destructor

Original issue reported on code.google.com by arg...@gmail.com on 29 Jun 2010 at 6:53

GoogleCodeExporter commented 9 years ago
Trivial fix.

Original comment by arg...@gmail.com on 29 Jun 2010 at 6:54

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the pointer.  This has already been fixed in svn-root, and will be 
part of the next release.

Original comment by csilv...@gmail.com on 29 Jun 2010 at 7:17

GoogleCodeExporter commented 9 years ago
This should be fixed in sparsehash 1.8, just released.

Original comment by csilv...@gmail.com on 29 Jul 2010 at 9:53