basnijholt / adaptive-lighting

Adaptive Lighting custom component for Home Assistant
https://basnijholt.github.io/adaptive-lighting/
Apache License 2.0
1.9k stars 136 forks source link

Add ability to switch to manual mode for only brightness #166

Closed gderber closed 2 years ago

gderber commented 3 years ago

First to help understand my configuration, I have set up an adaptive-lighting entity for each light fixture. This way I can set one fixture to manual while leaving the others alone.

During the day, I like to have the color temperature change the whole day. Sometimes I like to decrease the brightness level (especially a lamp near my desk). I still want the color temperature to change.

So the ability to switch brightness control to manual, while leaving the rest of the system running would be helpful.

I'm thinking something along the lines of

if brightness is changed: if brightness_only_switch: set adaptive_lighting_brightness "off" else: set adaptive_lighting_to_manual: "on"

With the idea being if I manually change the color value it'll turn the whole thing off, while if it's only the brightness I changed it'll only turn off the brightness control.

RubenKelevra commented 3 years ago

Hey @gderber,

thanks for your input, I think we have this already on our todo list:

https://github.com/basnijholt/adaptive-lighting/issues/132

If you agree I would like to mark this as a duplicate. If not, please elaborate why this won't cover your usecase :)

gderber commented 3 years ago

It might be covered by #132, but I am not certain.

I am not sure how simply turning off the brightness adjustment if I manually adjust the brightness while still leaving the color temperature adjustment active relates to multiple light "modes"

Edit: Short answer is, I don't see enough information on #132 to know one way or the other if #132 covers this.

woobins commented 2 years ago

I would like this feature as well since we often turn down the brightness while watching a movie but I'd still like the color temp to be adjusted. I'm not sure that #132 covers this either.

RubenKelevra commented 2 years ago

Hey @gderber,

I think we found a good solution on our roadmap for this:

as well as manual overrides with a delta:

Hey @woobins,

I think the manual override is what you're waiting for as well. :)

Make sure to vote on the points in the roadmap which would improve your usecase! :)

If something important is missing, LMK.

michaelcrossland1979 commented 1 year ago

It be nice to have the flip where you can set the colors to whatever you like but have you stuff so that the brightens is that only thing that changes not the light tone or color.

RubenKelevra commented 1 year ago

@michaelcrossland1979 wrote:

It be nice to have the flip where you can set the colors to whatever you like but have you stuff so that the brightens is that only thing that changes not the light tone or color.

What's wrong with the exposed switch to turn off the adaption of color (temperature) Adaptive Lighting is currently providing?

michaelcrossland1979 commented 1 year ago

Well that the thing some lights don't play nice with that at all. like the Govee ones that you can pick up very easily at Lowes stores or even online and they do a great job but they don't play nice with HA as someone had to come up with a 3rd party way to get the lights and other things to they make to be able to be used without the need for Bluetooth that is if your setup would even let you use Bluetooth to begin with. So all I'm asking is for a way to be able to not have to set any color as a thing for those of us that can't go whole hog with are setups. because when that is set the color is still past through to the Govee lights and they still act on that as if I was asking for the change to happen. I know it's not the doing of the addon it's the hacked way they forced us to use there stuff but I'm sure that I'm not the only one that has found that there lights don't care if that set and if any color is set it acts on it when the addon does its thing.

RubenKelevra commented 1 year ago

Hey @michaelcrossland1979,

I don't think I can follow your setup and train of thoughts here fully...

Would you mind creating a new ticket for this?

The exact type devices itself doesn't matter much, it's just important how HA "sees" it.

So just download the diagnostic data for the device and add it to the new ticket:

Screenshot_2023-05-31-11-30-33-308_io homeassistant companion android

michaelcrossland1979 commented 1 year ago

Well I'll just have to find some other way to deal with it my self. Because in the case of the 2 lights that I don't want it to change colors on those are outside lights and if left with the warmer colors you can guess what happens not to long after sun goes down all the bugs come right for those lights unless they are left in a very dark red color. But otherwise have no problems with it for the main house lights.

michaelcrossland1979 commented 1 year ago

See there is a very good use case for a advacted setting like that where the user can disable the color part but leave the dimming part alone. That or say when my plex server gets done playing something and I would just like my lights that where dimmed using webhoocks to stay that nice deep red but to just come back up to the bightens of what the rest are set at. Because don't know about you but have you sat in almost dark for 2 or 3 hours with just the TV and some low lights running at dark red and then have pop right up to a warm whitgh light that will blind you? I know I have and it's no fun what so ever.

RubenKelevra commented 1 year ago

@michaelcrossland1979 wrote:

See there is a very good use case for a advacted setting like that where the user can disable the color part but leave the dimming part alone.

Sure, but such a function is already implemented.

You can just turn the switches on/off, Adaptive Lighting exposes, to either turn on/off the brightness adjustments or the color (temperature) adjustments.

I'm not sure why you're asking for such a function - what's wrong with the current one?