Accent colors at daytime

basnijholt / adaptive-lighting

Adaptive Lighting custom component for Home Assistant

https://basnijholt.github.io/adaptive-lighting/

Apache License 2.0

1.82k stars 134 forks source link

Accent colors at daytime #40

Open Oekn5w opened 3 years ago

Oekn5w commented 3 years ago

I'd like to have an accent color on my lights, so you basically choose the color when the switch would generate a white light.

I'm already working on this and I'd like to know the other's opinion on this feature (Basically whether I should PR the changes).

If you're interested, my usability concept is like this:

add another switch to enable / disable this
color can be given via yaml or service call (new service: set_accent_color), yaml overrides last_state on startup
yaml also configs the interpolation endpoints (based on the internal percentage)

Functionality:

below the lower threshold the functionality isn't affected (nighttime color temperatures)
above said threshold, the rgb values are interpolated between the "default" rgb and the given accent color

Opinions?

R3yn4ld commented 3 years ago

Hi, that's a nice idea. However, it may break the circadian rythm?

However, having accent (minimum) brightness would be awsome ! Use case: while dinning I wan't a 100~50% brightness curve but then, during the evening, a 100~1% curve.

RubenKelevra commented 2 years ago

I'm currently in the process of doing version 2. This will be added/fixed.

Keep this ticket open until you can verify that it's properly working in the upcoming version 2.

Oekn5w commented 2 years ago

I've added this shortly after me opening the issue, I don't know if it's in my fork though. Let me see. I don't remember why I didn't PR it

Oekn5w commented 2 years ago

Ah I didn't fork it, I've directly added the feature in my repo that keeps all of my custom stuff, I'll make a branch

Oekn5w commented 2 years ago

@RubenKelevra I dunno why I didn't PR this (possibly because I didn't implement, test all the UI setup part, because I'm not using it), but here you go, upstream changes merged just now: https://github.com/Oekn5w/adaptive-lighting/tree/accent_colors

RubenKelevra commented 2 years ago

Hey @Oekn5w I've merged it into a branch in this repo and I'll have a look at it.

v1 has a feature freeze due to the v2 development :)

Thanks for your contribution!