search

basnijholt / adaptive-lighting

Adaptive Lighting custom component for Home Assistant
https://basnijholt.github.io/adaptive-lighting/
Apache License 2.0
1.86k stars 135 forks source link

Unconventional sunrise sunset times #830

Open b-rad15 opened 11 months ago

b-rad15 commented 11 months ago

Rebased this branch https://github.com/basnijholt/adaptive-lighting/pull/535 addressing https://github.com/basnijholt/adaptive-lighting/issues/105 given the updates since it was created. It works fine adding it to my homeassistant integration but I can't get the tests to run correctly (Triggering pytest-socket somehow and causing every one to instantly stop, not an actual test failure) so it would help if someone who has had success running those before could make sure something else wasn't unintentionally broken.

th3w1zard1 commented 11 months ago

I'm confused. So you forked over my existing PR at #535, then you modified it, then you submitted a new pull request for us asking to merge this. But more importantly, why is your PR showing that I committed here two days ago? Is this a github bug? image

protyposis commented 10 months ago

Is this a github bug?

This is standard behavior of Git and not related to GitHub. @b-rad15 rebased your branch, which created copies of your original commits. Git automatically assigned you as original author of these commits, and @b-rad15 as the committer. He ran the rebase operation two days ago (from the time of your post), hence the date. So this is basically Git's way of crediting your past work to you, even when copied by someone else.