basnijholt / adaptive-lighting

Adaptive Lighting custom component for Home Assistant
https://basnijholt.github.io/adaptive-lighting/
Apache License 2.0
1.98k stars 141 forks source link

Lights controlled as group are not marked as manually controlled #945

Open atomicus opened 8 months ago

atomicus commented 8 months ago

Home Assistant Adaptive Lighting Issue Template

Bug Reports

If you need help with using or configuring Adaptive Lighting, please open a Q&A discussion thread here instead.

Before submitting a bug report, please follow these troubleshooting steps:

Please confirm that you have completed the following steps:

Required information for bug reports:

Please include the following information in your issue.

Issues missing this information may not be addressed.

  1. Debug logs captured while the issue occurred. See here for instructions on enabling debug logging:
  1. Your Adaptive Lighting configuration:

adaptive_lighting:

  - name: "Bedroom"
    lights: [light.bedroom_ambient, light.bedroom_ambient_2]
    prefer_rgb_color: true
    initial_transition: 10
    transition: 0
    sunrise_time: "07:30:00"
    sunset_time: "20:00:00"
  1. Describe the bug and how to reproduce it:

AL stoped marking lights as manually controlled when light is controlled by a group (HA group, not zigbee).

Following code tha reacts to my pilot:

- alias: Ikea remote
  id: "1499"
  description: ""
  use_blueprint:
    path: ikea_remote.yaml
    input:
      remote: sensor.pilot_1_action
      button_on:
        - type: brightness_increase
          device_id: e0f41cbd8d042797468be62c40b663cf
          entity_id: light.automatic
          domain: light
      button_off:
        - device_id: e0f41cbd8d042797468be62c40b663cf
          entity_id: light.bedroom_ambient
          type: brightness_decrease
          domain: light
      button_left_click:
        - service: input_boolean.toggle
          entity_id: input_boolean.night_enabled
  1. Works: When buttton off is presed and a brightness is decreases only of a single light.
  2. Doesn't work: When button on is pressed and brightness is increase for a group of lights (they go back to AL control after few seconds).

This is referenced in state of AL when manual control contains only lights changed directly, but does not include lights of group.

  1. Steps to reproduce the behavior:

  2. Add light (controlled by AL) to group

  3. Set brightness to group manually. Light will come back to AL brightness after a while

I'm sure this was working before, but not sure in which version.

atomicus commented 8 months ago

For clarification

ncd7 commented 4 months ago

Now we seem to have the opposite problem for hue groups. If you simply turn on a light entity which represents a group of hue lights (using the official hue integration), all the individual lights end up show up under the "manual_control" attribute of the switch.

malodie commented 3 months ago

I'm having mixed results with this. In my living room, it seems like light.living_room has no problem whatsoever listing out the lights in the group and then applying them under manual control.

In my office, I can't get any of them to be manual control, regardless of whether it is a group or not.