basnijholt / adaptive-lighting

Adaptive Lighting custom component for Home Assistant
https://basnijholt.github.io/adaptive-lighting/
Apache License 2.0
1.71k stars 127 forks source link

Take_over_control no longer working after 2024.3? #954

Open jhemak opened 3 months ago

jhemak commented 3 months ago

I have had no issues with this integration until 2024.3. Now, when I manually change bulb settings the take_over_control feature does not seem to have an impact and AL reverts my manual changes after a few seconds. Has anyone else experienced this problem?

wgregorian commented 3 months ago

+1, same behavior.

Core 2024.3.3 Supervisor 2024.03.1 Operating System 12.1 Frontend 20240307.0

langas6 commented 3 months ago

I seem to have a similar issue. Manual control either doesn't stay and reverts back to AL lighting mode, or won't come out of manual control back to AL

Arie6414 commented 3 months ago

+1 Same behavior. After manual reloading the specific configuration it starts working again as expected.

2024-04-01 18:10:29.035 DEBUG (MainThread) [custom_components.adaptive_lighting.switch] Adaptive Lighting: 'light.lamp_kantoor' is being manually controlled, stop adapting,

jhemak commented 3 months ago

@Arie6414 - what do you mean by manual reloading the specific configuration?

Arie6414 commented 3 months ago

@Arie6414 - what do you mean by manual reloading the specific configuration?

If you go to the integration, you will see your adaptieve lighting configurations… next to that you will have 3 dots on top of eachother (the option menu), there is a possibility to reload the configuration.

It looks like it does the Same as reloading your automations.

jhemak commented 3 months ago

Ah ok. I don’t think that is relevant to the problem I am having, but I know what you mean.

Arie6414 commented 3 months ago

Ah ok. I don’t think that is relevant to the problem I am having, but I know what you mean.

It could also be coincidence.. i also had the Same thing. And after reloading it did not occured anymore so far. Something strange i found in the log as well, was that “take over” was not enabled. But in the UI i enabled it.

langas6 commented 2 months ago

Seems the reloading is only a temp fix, works each time to get the lights right at that point in that instance, but then when it applies manual colour and brightness adjustments, either it doesn't work, or does and doesn't return back to AL mode again. Unless I do another reload

basnijholt commented 2 months ago

I am currently away from my home and somehow my HA server is down, so I have no means of testing anything at the moment.

I will be back at the end of the month. Will try to reproduce this then.

langas6 commented 2 months ago

Not a problem, another thing I thought to try is recreate from scratch the different entries and initial testing has been positive. But only for one of the entities... Seems a bit hit and miss if it works and does what it says it's going to do, very very strange...

Thank you so much for looking into it! Loving the software a tonne! Just having a slight hickup 👍👍

langas6 commented 2 months ago

Found a way to get around it with the automations, since the AL doesn't apply correctly when the lights turn on, you can set 3 extra actions after the "turn on" of the lights:

Set one action to "turn off: switch" for the AL for the zone you have it set in (if you have multiple) Then a 500ms "wait" action Then a "turn on: switch" for the same AL

You'll have a .5 second where it's the wrong colour/brightness, but at least it works again until it's 100% fixed. As i was having to do the reload 4-5-6 times a day to get the lights right, now just have it that whenever the lights are turned on, the AL setting is reloaded and it's working fine now.

EDIT: Just had another thought, if you have lights that are on for a long time and you want to have them adjust, set another automation to run every 5-10 mins or whatever that checks if the lights are on and runs the same "switch: turn off/on" commands. Then they will still adjust when the lights are on, not just when they are turned on.

Just if anyone else could use this info for the time being

langas6 commented 1 month ago

Hi all, Thought i'd check in here to see if there was any movement :) Didn't want to push as i'm very appreciative of the software to start with, but thought i'd see how things were going on this one :)

th3w1zard1 commented 1 month ago

anybody know the last version that worked? since i'm the one that fixed take_over_control last time, i might be best qualified to take a look at it.

Arie6414 commented 1 month ago

I think it was 1.19.1

Met vriendelijke groet,

Arjen van de Belt Verstuurd vanaf mijn IPhone

Op 14 mei 2024 om 04:42 heeft Benjamin Auquite @.***> het volgende geschreven:



anybody know the last version that worked? since i'm the one that fixed take_over_control last time, i might be best qualified to take a look at it.

— Reply to this email directly, view it on GitHubhttps://github.com/basnijholt/adaptive-lighting/issues/954#issuecomment-2109170322, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A65HXV6X45QP6A23CN7QHQ3ZCF2ZDAVCNFSM6AAAAABFL7K6SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZGE3TAMZSGI. You are receiving this because you were mentioned.Message ID: @.***>

langas6 commented 1 month ago

anybody know the last version that worked? since i'm the one that fixed take_over_control last time, i might be best qualified to take a look at it.

Not 100%, but i'm on 2024.5.3 and it's not working, i think it might have been 2024.2 where it was working.

jhemak commented 1 month ago

I believe it worked through 2024.2.5. It stopped working with 2024.3, and I assumed it had something to do with the significant performance improvements at startup that were introduced in that release.

basnijholt commented 1 month ago

I believe this is now fixed in 1.21.3.

jhemak commented 1 month ago

Sorry to say, not quite. I am on 1.21.3 and still seeing the same problem. Though I will add that the take over control does work intermittently -- in both this release and the last one. So net/net, I'm seeing the same with 1.21.3 as I was with 1.21.2.

jhemak commented 1 month ago

Continuing to see the same problem in 1.22.0

tpsherratt commented 4 weeks ago

I too am still seeing this issue on 1.22.0

wise-rice commented 1 week ago

+1

basnijholt commented 1 week ago

I really cannot reproduce the issue. All is working fine for me at my home.

basnijholt commented 1 week ago

Without logs that show what happens there is no way for me to solve this.