deprecate Learner2D #57

Closed basnijholt closed 5 years ago

(original issue on GitLab)

opened by Joseph Weston (@jbweston) at 2018-07-09T14:51:40.135Z

Once LearnerND becomes good enough we should remove Learner2D, as it will no longer be needed.

originally posted by Bas Nijholt (@basnijholt) at 2018-07-09T16:40:11.612Z on GitLab

If good enough == better than.

originally posted by Joseph Weston (@jbweston) at 2018-07-09T16:57:09.452Z on GitLab

good enough == as good as?

originally posted by Jorn Hoofwijk (@Jorn) at 2018-07-13T07:59:33.461Z on GitLab

I think good enough == better than the Learner2d.

Because right now the learner2d takes all the points into account when computing the loss for each triangle. Although this is something we want to lose, this has some benefits, as you can for example, take the second derivative of the function into account (or as the default loss is currently implemented, taking the deviation from the linear interpolation + gradient)
Also I am not sure if people have written custom loss functions, which are going to be different for the LearnerND, so it is not a drop-in replacement.