basnijholt / addon-otmonitor

OpenTherm Monitor Home Assistant supervisor add-on
17 stars 11 forks source link

Add websocket to nginx #9

Closed andriej closed 3 years ago

andriej commented 4 years ago

Currently, even when using proper setup with SSL, in "messages" there's an error about websocket in browser. Adding otmonitor webpage to nginx-proxy with websocket support makes it working properly (so the messages and charts update themselves automatically).

I think it's worth adding in nginx configuration

basnijholt commented 4 years ago

I agree!

However, unfortunately, I currently have no time to figure out how to do it.

If you figure it out, please create a PR 👍

andriej commented 4 years ago

I will try to dig into that later, as turning on websocket doesn't solve the issue. It's HA's ingress that's causing some files to be 404 error.

Not a priority, as it works tho.

fliphess commented 3 years ago

~I suspect this has something to do with the newer ciphers for tls1.3 that do not work for tls1.2 (websockets do not support 1.3 yet afaik)~

It's the regex for the socket url, we can fix it upstream by updating the regex as mentioned in #23

I'm running into this issue myself with my setup and use of the companion app, so I've to do some debugging anyway. I think I can create a fix later this month.

fliphess commented 3 years ago

I've created a merge request upstream that should fix this issue :)

basnijholt commented 3 years ago

Nice! I see it's merged upstream. Do we require any changes here?

fliphess commented 3 years ago

I don't think so: We build straight from master so reloading and rebuilding the container should work :)

fliphess commented 3 years ago

I think we can close this one can't we? :)

basnijholt commented 3 years ago

Yes, you fixed that one 😇