search

basnijholt / miflora

☘️🌡🌼🥀🏡 Mi Flora Plant sensor Python package
MIT License
362 stars 99 forks source link

Modify init call for abstract backend to pass retries parameter #108

Closed rlmalisz closed 5 years ago

rlmalisz commented 6 years ago

As above.

ChristianKuehnel commented 6 years ago

Thx for the PR, it change looks good!

But the tests also need changes as there is a new parameter. Can you please also fix the tests?

ChristianKuehnel commented 5 years ago

After looking at the change more thoroughly: This will not implement the retries correctly. For this to work, we need to set the retries in the bltewrap library. There it's currently hard-coded: https://github.com/ChristianKuehnel/btlewrap/blob/master/btlewrap/bluepy.py#L8-L9

See issue: https://github.com/ChristianKuehnel/btlewrap/issues/2