search

basnijholt / miflora

☘️🌡🌼🥀🏡 Mi Flora Plant sensor Python package
MIT License
362 stars 99 forks source link

Fixes #144 by removing `typing` dep for py3.5+ #145

Closed wolph closed 3 years ago

wolph commented 4 years ago

For Python 3.5 and above the typing module is integrated in Python so it has no effect. But it seems to break pip in certain cases as shown in #144

balloob commented 3 years ago

typing is built into Python 3.5+. According to setup.py, it only supports Python 3.5+, so we should be able to remove it.

https://github.com/open-homeautomation/miflora/blob/ebda66d1f4ba71bc0b98f8383280e59302b40fc8/setup.py#L26-L29

Besides the reference in requirements.txt, it's also referenced in setup.py.

balloob commented 3 years ago

@open-homeautomation would you be able to take a look at this PR? Any project that uses modern Python versions has to pip3 uninstall typing after installing miflora, but that might not be clear for new users.

bdraco commented 3 years ago

@ChristianKuehnel Can you take a look?

ChristianKuehnel commented 3 years ago

Looks good to me!

Note: I also bumped the "btlewrap" dependency to 0.0.10, as it also depended in typing.

balloob commented 3 years ago

Thanks!

Could you also publish a new release?

ChristianKuehnel commented 3 years ago

Sorry, I do not have the premissions for that.

@open-homeautomation can you please create a new release?

balloob commented 3 years ago

@open-homeautomation would really like to see a new release.

ghost commented 3 years ago

Sorry, I can't find the time to maintain this. @ChristianKuehnel interested to take over this repository in the PIP releases?

ChristianKuehnel commented 3 years ago

Thx for the offer, but I'm not using miflora any more. Sorry 😞 . Maybe @ThomDietrich ?

I've moved to an ESPHome based solution. This proved to be much more reliable than Bluetooth on Linux.