basnijholt / miflora

☘️🌑🌼πŸ₯€πŸ‘ Mi Flora Plant sensor Python package
MIT License
366 stars 98 forks source link

Proposals for improvements #22

Closed ChristianKuehnel closed 7 years ago

ChristianKuehnel commented 7 years ago

After using miflora for a while I noticed some things that I was not happy with:

For these reasons I decided to create a new implementation on top of BluePy: https://github.com/ChristianKuehnel/plantgateway/blob/master/plantgw/misensor.py

One comment on speed: Getting the data (battery + measurements) and forwarding it via MQTT takes <10sec per sensor.

If you're interested we could discuss merging my low-level parts with your high-level API...

ghost commented 7 years ago

Feel free to post a pull request with these improvements.

ghost commented 7 years ago

I recommend to split these improvements into different pull requests to make them easier to read.

ChristianKuehnel commented 7 years ago

Splitting does not make sense, as I had to rewrite the whole low-level communication. Pull request to follow.