Implementation of historical data retrieval

basnijholt / miflora

☘️🌡🌼🥀🏡 Mi Flora Plant sensor Python package

MIT License

363 stars 98 forks source link

Implementation of historical data retrieval #27

Closed Happyzippy closed 6 years ago

Happyzippy commented 7 years ago

A proposal for reading historical measurement data off the device

Builds upon pull request #23 as speed and connection control was needed

Notes:

Only tested against firmware version 2.9.2
Changes cache and retry implementations for decorators
Introduces a simple mock bluepy Peripheral to imitate the device during tests

ThomDietrich commented 7 years ago

@open-homeautomation What's the state of this PR? This is a massive change set I'd like to benefit from. @Happyzippy is your master stable and further maintained?

Edit: saw the discussions in PR 23 too late. Seems like we'll have to wait.

ChristianKuehnel commented 6 years ago

closing this PR, as the history reading feature merged after the refactoring in PR #78