search

basnijholt / miflora

☘️🌡🌼🥀🏡 Mi Flora Plant sensor Python package
MIT License
363 stars 98 forks source link

Implemented bluepy backend #45

Closed ChristianKuehnel closed 6 years ago

ChristianKuehnel commented 6 years ago

This is a first implementation of the bluepy-based backend. The code for this is much simpler as bluepy library already provides all of the dirty work. But it requires the bluepy library which is not available on all platforms.

For this change I had to refactor the interface between the miflora_poller and the backends: They are now exchanging bytes and byte arrays instead of strings. I suppose bytes are the more natural way of interacting on protocol level sensor than strings.

I also added more tests, all of which are passing on my machine.

ThomDietrich commented 6 years ago

I'd love to see a few lines added to the README, besides that: LGTM!

ChristianKuehnel commented 6 years ago

good point, I extended the documentation and along the way I upgraded the Readme to Markdown and also created a CONTRIBUTING.md, or at least a first version thereof...

ThomDietrich commented 6 years ago

Wonderful. I appreciate the change to markdown.

LGTM