basnijholt / miflora

☘️🌑🌼πŸ₯€πŸ‘ Mi Flora Plant sensor Python package
MIT License
363 stars 98 forks source link

flake8 Integration #53

Closed ghost closed 6 years ago

ghost commented 6 years ago

Added a few lines to tox.ini after reading this . Hope this works.

ChristianKuehnel commented 6 years ago

Hi @ydjain,

thx for the patch. How do you call flake8 from tox? In Home Assistant, flake8 is automtically called when running tox. When I run tox, I do not see any results from flake8 and I would expect to get a lot of warnings...

ghost commented 6 years ago

Hi I have realised my stupidty :stuck_out_tongue_closed_eyes: and have made changes accordingly...I have added pylint too...all issues raised by flake8 have been resolved

ChristianKuehnel commented 6 years ago

looks great, thx!