search

basnijholt / miflora

☘️🌡🌼🥀🏡 Mi Flora Plant sensor Python package
MIT License
363 stars 98 forks source link

New PyPI release, release automation #54

Closed ThomDietrich closed 6 years ago

ThomDietrich commented 6 years ago

Hey,

  1. with the new backend and bluepy on the way, I'd suggest a new release soon.

  2. Related to that PyPI deployment automation would be an option, see: https://docs.travis-ci.com/user/deployment/pypi/

ghost commented 6 years ago

When the new release is tested, we can create a new PyPi version. I'm not a fan of automated deployment. I don't think we'll need to create releases very often. Therefore manual deployment by me shouldn't be a big deal.

ThomDietrich commented 6 years ago

That's of course also an option! Just to be sure, you saw that the deployment supports builds based on versioned tags, right?

ghost commented 6 years ago

Not sure what you mean by "versioned tags". Right now, version is hardcoded in setup.py

ThomDietrich commented 6 years ago

https://docs.travis-ci.com/user/deployment/pypi/#Deploying-tags

Such a configuration would release a new build to PyPI automatically BUT only when you tag a certain commit as a new version (e.g. "0.2.0"). Probably what you want, just less manual work ;)

ChristianKuehnel commented 6 years ago

@ThomDietrich before releasing I would like to spend some more time on adding more tests: https://github.com/open-homeautomation/miflora/issues/46

We had quite a lot of changes in the last days and I would like to be a little bit more :wink: sure that I did not break anything...

Concerning the way we do releases: I would also like to use the git tag feature to mark the versions as releases.

Having the PyPi stuff done by TravisCI would also be a nice thing to have.

ChristianKuehnel commented 6 years ago

I'm done with my tests, did not find any bugs --> I'm ready for a new release...

ghost commented 6 years ago

I've seen quite some changes in the last days. Are there any open issues that should be implemented in the next days? Otherwise I would create a new release soon.

ChristianKuehnel commented 6 years ago

Hey @open-homeautomation, I just implemented and merged the last things I had on my mind. I'm ready to release...

@ThomDietrich , do you have any changes in the pipeline?

ThomDietrich commented 6 years ago

I would have liked to add the cache control functions ( #36 ) but my time is short currently and I can't promise to get them tested today or tomorrow. Hence I'd be okay to merge now. They can be part of the next release. It would anyhow be a good idea to release in quicker cycles

ghost commented 6 years ago

I'll wait until the weekend.

ghost commented 6 years ago

0.2 release has been created and uploaded to PyPi

ThomDietrich commented 6 years ago

Thanks @usul27! I've taken the chance and sorted out the project tags: https://github.com/open-homeautomation/miflora/releases