basnijholt / miflora

☘️🌑🌼πŸ₯€πŸ‘ Mi Flora Plant sensor Python package
MIT License
363 stars 98 forks source link

Fix Coveralls setup #56

Closed ChristianKuehnel closed 6 years ago

ChristianKuehnel commented 6 years ago

There is a Travis CI configuration for Coveralls but it does not yet collect any metrics. This should be fixed.

fuzzmz commented 6 years ago

See my comment on #52. After enabling Travis CI and Coveralls integration from their respective dashboards, if this issue will still be relevant I can take a look.

ChristianKuehnel commented 6 years ago

@fuzzmz Both are enabled for my fork of the repository. Travis is working, but Coveralls does not show any data. Something must be still wrong in the configuration: https://travis-ci.org/ChristianKuehnel/miflora https://coveralls.io/github/ChristianKuehnel/miflora

Do you have any ideas on what the issue might be?

fuzzmz commented 6 years ago

Thanks, will take a look at it.

On Oct 21, 2017 09:32, "ChristianKuehnel" notifications@github.com wrote:

@fuzzmz https://github.com/fuzzmz Both are enabled for my fork of the repository. Travis is working, but Coveralls does not show any data. Something must be still wrong in the configuration: https://travis-ci.org/ChristianKuehnel/miflora https://coveralls.io/github/ChristianKuehnel/miflora

Do you have any ideas on what the issue might be?

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/open-homeautomation/miflora/issues/56#issuecomment-338368118, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRfjYm3qdl7MH26un2n9dAIspxaeDEUks5suZACgaJpZM4P_5bO .

fuzzmz commented 6 years ago

Work is a bit hectic so I'm not sure I'll be able to look into this any time soon, sorry.

Fedalto commented 6 years ago

I can take a look into this