search

basnijholt / miflora

☘️🌡🌼🥀🏡 Mi Flora Plant sensor Python package
MIT License
363 stars 98 forks source link

check python version during loading of the module #61

Closed ChristianKuehnel closed 6 years ago

ChristianKuehnel commented 6 years ago

We have two open issues (https://github.com/open-homeautomation/miflora/issues/29 and https://github.com/open-homeautomation/miflora/issues/20), that are probably caused by using python 2.7.

So a implemented a check to give a proper error message when using an old python version. To be able to test this, I had to refactor the tests a bit.

Maybe a more general question: Which python versions do we want to support? Currently I'm checking if the version >= 3.4? Is that what we want?

ChristianKuehnel commented 6 years ago

No feedback after 4 weeks --> merging the change

ThomDietrich commented 6 years ago

Sorry. 3.4 would also have been my choice... or rather is over in my mqtt-daemon project