basnijholt / miflora

☘️🌑🌼πŸ₯€πŸ‘ Mi Flora Plant sensor Python package
MIT License
363 stars 98 forks source link

Support for historical data ? #67

Closed xavrr closed 6 years ago

xavrr commented 6 years ago

Hi there, Thanks for this great work, It seems like the sensors actually store historical data, any plans to support querying these ?

ThomDietrich commented 6 years ago

Yes, in fact there is a pull request implementing this feature available, see: https://github.com/open-homeautomation/miflora/pull/27 I believe due to recent developments in this repository the PR was not addressed again till now but now would be a good time to fix the pull request and go forward merging it. @Happyzippy wdyt?

xavrr commented 6 years ago

Thanks Thom, I'll have a look to it

ChristianKuehnel commented 6 years ago

Implemented here: https://github.com/open-homeautomation/miflora/pull/78