Closed ChristianKuehnel closed 6 years ago
This code coverage metric is wierd. I removed 2 lines of code, so obviously the code coverage of the entire file goes down as the uncovered lines have more weight now. This should not raise a coverage error.
Anyway, I would also merge this file despite the small decrease in the coverage...
Also they are a bit annoying :) Maybe it's enough to post a link once or disable the posting completely? After all you can always go to https://coveralls.io/github/open-homeautomation/miflora
Anyhow, I just wanted to mention, that I am in a hectic phase of my life right now and will not be able to do any significant contributions in the next four months. Sorry for that but thanks for your tremendous work here 😃 May I add a humble request? It would be nice to have my clean cache idea implemented #36. Would you take it on?
Best! Thomas
Hey @ThomDietrich, no problem. Wish you all the best during your hectic times.
This is a bit of cleanup work.