search

basnijholt / miflora

☘️🌡🌼🥀🏡 Mi Flora Plant sensor Python package
MIT License
363 stars 98 forks source link

refactored _parse_data function to use Python's built-in struct.unpack… #73

Closed ChristianKuehnel closed 6 years ago

ChristianKuehnel commented 6 years ago

This is a bit of cleanup work.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 85.467% when pulling b45cf4415bde835fdbe15c22cebc64ba602b60ca on ChristianKuehnel:unpack into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 85.467% when pulling 76ea7ed20212c5d359841bab1f84b6f715e35d01 on ChristianKuehnel:unpack into 0af1185abfbfe35ed2202b0ebab9e94a646efe4a on open-homeautomation:master.

ChristianKuehnel commented 6 years ago

This code coverage metric is wierd. I removed 2 lines of code, so obviously the code coverage of the entire file goes down as the uncovered lines have more weight now. This should not raise a coverage error.

Anyway, I would also merge this file despite the small decrease in the coverage...

ThomDietrich commented 6 years ago

Also they are a bit annoying :) Maybe it's enough to post a link once or disable the posting completely? After all you can always go to https://coveralls.io/github/open-homeautomation/miflora

Anyhow, I just wanted to mention, that I am in a hectic phase of my life right now and will not be able to do any significant contributions in the next four months. Sorry for that but thanks for your tremendous work here 😃 May I add a humble request? It would be nice to have my clean cache idea implemented #36. Would you take it on?

Best! Thomas

ChristianKuehnel commented 6 years ago

Hey @ThomDietrich, no problem. Wish you all the best during your hectic times.