search

basnijholt / miflora

☘️🌡🌼🥀🏡 Mi Flora Plant sensor Python package
MIT License
362 stars 99 forks source link

clean cache #77

Closed ChristianKuehnel closed 6 years ago

ChristianKuehnel commented 6 years ago

This is a manual rebase/cherrypick of https://github.com/open-homeautomation/miflora/pull/36.

We now offer 2 new functions to manually check/influence the cache:

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 92.308% when pulling d087f9cdc028c4ed5a9f6c7a52db9b2137754552 on ChristianKuehnel:ThomDietrich-patch-4 into c31a4a950d92462815ce500d628806a2ada670fb on open-homeautomation:master.

ChristianKuehnel commented 6 years ago

Hey @ThomDietrich,

can you have a look if this is what you wanted?

ThomDietrich commented 6 years ago

Hey! Yes looks good! At a later point we should maybe rethink the whole cache and cache timeout concept. The current way of operation is a bit intransparent, which led to me implementing these helper functions. It stands to question if instead the caching behavior should be changed.

Anyhow, for now I think we are perfectly fine with the PR as is.