search

bassjobsen / typeahead.js-bootstrap-css

LESS / CSS code for using typeahead.js with Bootstrap 3
MIT License
192 stars 127 forks source link

typeahead v0.11.1 #11

Closed dongliu closed 8 years ago

dongliu commented 9 years ago

The CSS class name changed in v0.11.1, see https://github.com/twitter/typeahead.js/blob/v0.11.1/src/typeahead/www.js for details.

We will need to add lines like 

.tt-menu {
&:extend(.dropdown-menu);
}

and keep .tt-dropdown-menu still there to be compatible with old versions. I will submit a pull request.

HakanL commented 9 years ago

Can you do a commit for the compiled CSS as well?

dongliu commented 9 years ago

I am not sure if you want this https://github.com/hyspace/typeahead.js-bootstrap3.less/blob/master/typeahead.css

HakanL commented 9 years ago

I was thinking a commit patch against this repository. But I'm not the maintainer, I was just looking for a CSS fix for typeahead v0.11.1 and found your patch against the less file.

dongliu commented 9 years ago

I assume this repository suggests you to compile your own. Here is one I just compiled https://gist.github.com/dongliu/4af9c0622a241c533a84 against Bootstrap v3.3.5

HakanL commented 9 years ago

In the readme they were linking to the src/css file: https://github.com/bassjobsen/typeahead.js-bootstrap-css/blob/master/typeaheadjs.css but I'm not sure if it's meant to be a standalone or something else. Maybe the author can comment on that.

bassjobsen commented 8 years ago

should work now?