search

bassjobsen / wp-defer-loading

Defer loading javascript for WordPress. Without any additional library. Just the way Google ask you to do it.
4 stars 2 forks source link

Use Google Libraries #13

Open bassjobsen opened 11 years ago

bassjobsen commented 11 years ago

Issue #11 seems due to Use Google Libraries (http://wordpress.org/plugins/use-google-libraries/) or at least in the case described by @mattday.

bassjobsen commented 11 years ago

The Use Google Libraries writes a <script type='text/javascript'>try{jQuery.noConflict();}catch(e){};</script> for jQuery or jQuery dependent code load from CDN. Adding a noConflict() seems reasonable cause since WP 3.6 the local version of jQuery does the same.

This code breaks the plugin at the moment.

If you want to use Use Google Libraries you will have to remove the echoing of the line mentions above (line 447 in use-google-libraries.php). This won't be a problem in most cases.

I also will post on issue on the plugin's support form to ask for enqueue the noConflict() too or make it optional.

NOTE 1 at the moment "Use Google Libraries" won't work for the newest versions of PHP, see: http://wordpress.org/support/topic/redefining-already-defined-constructor-error-1

NOTE 2 we should consider the profits of using CDN loading in combination with defer loading. After this issue #2 should be reopened maybe. At the moment the only profit seems for first time users of your site. But they will be only profit when the Library could be load from cache or load faster from a more local CDN then from your own server.