bassmanitram / actions-for-nautilus

An extension to the Gnome "Files" file manager that allows you to add arbitrary actions to the file selection context menu.
Apache License 2.0
165 stars 16 forks source link

repetition behaviour not working correctly #17

Closed biokomiker closed 1 year ago

biokomiker commented 1 year ago

Dear Martin,

reading carefully your manual I wanted to take the advantage of the repetition behaviour with SINGULAR placeholders. The command (echo %f) appears to be repeated but repeatedly on the first entry. That is what I understand from the output:

`COMMAND 0 ['echo', '/home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27']

COMMAND 1 ['echo', '/home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27'] /home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27

COMMAND 2 ['echo', '/home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27'] /home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27 /home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27

COMMAND 3 ['echo', '/home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27']

COMMAND 4 ['echo', '/home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27'] /home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27

COMMAND 5 ['echo', '/home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27'] /home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27 /home/georg/Bilder/Bilder (home-hd)/import/Sony RX-100M3/2022/2022-08-27 `

The behaviour is the same with %d, %f and %b.

bassmanitram commented 1 year ago

Hey. Ok I'll take a look... Thx for the report

bassmanitram commented 1 year ago

Lol - so it turns out that only %f amongst the SINGULAR placeholders had the bug in it, but the behaviour of some of the ANY placeholders was also not as described.

Testing the fix now

bassmanitram commented 1 year ago

Tests work, PR created https://github.com/bassmanitram/actions-for-nautilus/pull/18

Once merged this will form part of release 1.3 (later today, I'm hoping)

bassmanitram commented 1 year ago

Released as part of v1.3.0

biokomiker commented 1 year ago

Installed via deb, works like a charm - Thanks!

bassmanitram commented 1 year ago

Installed via deb, works like a charm - Thanks!

NP.